versions() bug fix macOS detection

CHANGELOG.md

@@ -100,6 +100,7 @@ Other changes
 
 | Version        | Date           | Comment  |
 | -------------- | -------------- | -------- |
+| 3.52.7         | 2018-12-29     | `versions()` bug fix macOS detection |
 | 3.52.6         | 2018-12-28     | `versions()` bug fix macOS |
 | 3.52.5         | 2018-12-28     | preparing automated tests, travis-ci integration, added dev-dependencies |
 | 3.52.4         | 2018-12-27     | `graphics().controllers` bugfix linux |

README.md

@@ -42,8 +42,6 @@ Lightweight collection of 35+ functions to retrieve detailed hardware, system an
 $ npm install systeminformation --save
 ```
 
-For production builds (to prevent installing `dev-dependencies`) be sure to set `NODE_ENV` environment variable to `production` befor running `npm install`
-
 ### Usage
 
 All functions (except `version` and `time`) are implemented as asynchronous functions. Here a small example how to use them:

lib/osinfo.js

@@ -367,21 +367,10 @@ function versions(callback) {
           functionProcessed();
         });
         if (_darwin) {
-          let filename = '/Library/Developer/CommandLineTools/';
+          const cmdLineToolsExists = fs.existsSync('/Library/Developer/CommandLineTools/');
-          fs.access(filename, fs.constants.F_OK, (err) => {
+          const xcodeExists = fs.existsSync('/Library/Developer/Xcode/');
-            if (!err) {
+          const gitHomebrewExists = fs.existsSync('/usr/local/Cellar/git');
-              exec('git --version', function (error, stdout) {
+          if (cmdLineToolsExists || xcodeExists || gitHomebrewExists) {
-                if (!error) {
-                  let git = stdout.toString().split('\n')[0] || '';
-                  git = (git.toLowerCase().split('version')[1] || '').trim();
-                  result.git = (git.split(' ')[0] || '').trim();
-                }
-                functionProcessed();
-              });
-            } else {
-              let filename = '/usr/local/Cellar/git';
-              fs.access(filename, fs.constants.F_OK, (err) => {
-                if (!err) {
             exec('git --version', function (error, stdout) {
               if (!error) {
                 let git = stdout.toString().split('\n')[0] || '';
@@ -393,9 +382,6 @@ function versions(callback) {
           } else {
             functionProcessed();
           }
-              });
-            }
-          });
         } else {
           exec('git --version', function (error, stdout) {
             if (!error) {